New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong "TAIL" edge label layout #905
Comments
And for information, the problem does not exist without container and without border nodes: sample in ELK live. |
I looked a bit at the code level to see if there was anything "obvious" between a different treatment for |
Not sure about all consequences, but this change fixes the problem:
|
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
I've done a corresponding pull request #906 |
As the corresponding commit has been merged, I think that this issue can be closed, with milestone 0.9.0, except if some additional tests are planned to be done. |
A test would be nice. Thank you for your effort @lredor |
Signed-off-by: Laurent Redor <laurent.redor@obeo.fr>
@soerendomroes I have added a test with #913 and associated data in eclipse/elk-models#17. |
The test also covers center and head labels. Even if only tail label is problematic in #905. But it could help to detect a possible regression later... |
The fix and tests have been merged on master branch so I consider this issue as solved. I think it can be added to 0.9.0 milestone |
It seems that the location of an edge label with property "edgeLabels.placement: TAIL" is non deterministic between several layouts.
Here is an example, each diagram is the result of the previous layout, you can see that the "begin" label move at each layout. The property "noLayout" is set to true to see the state before layout:
The corresponding successive layout results are like this:
The text was updated successfully, but these errors were encountered: