Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material: Overflow action in AppBar should be narrower #20133

Open
sir-boformer opened this issue Aug 2, 2018 · 2 comments
Open

Material: Overflow action in AppBar should be narrower #20133

sir-boformer opened this issue Aug 2, 2018 · 2 comments
Labels
a: fidelity Matching the OEM platforms better c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team

Comments

@sir-boformer
Copy link
Contributor

flutter_incorrect
@zoechi zoechi added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. a: fidelity Matching the OEM platforms better labels Aug 2, 2018
@zoechi
Copy link
Contributor

zoechi commented Jan 29, 2019

Is this still an issue?

To investigate we would need a minimal runnable reproduction
as a single file so that we can just copy your code into lib/main.dart of a new project and run to reproduce.

@zoechi zoechi added the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 29, 2019
@sir-boformer
Copy link
Contributor Author

sir-boformer commented Jan 30, 2019 •
edited

I'm currently unable to test it or write an example.

But looking at the source code, it doesn't look like the problem is solved.

The biggest issue is that the material spec defines that the "..." action button is actually smaller than the other buttons (hitbox should probably still be 48x48). I'm not sure what would be the best way to adresss this? Reduce the padding on both sides if the rightmost button is "..."?

#21153 is another issue of the app bar that could be fixed at the same time.

@no-response no-response bot removed the waiting for customer response The Flutter team cannot make further progress on this issue until the original reporter responds label Jan 30, 2019
@zoechi zoechi added this to the Goals milestone Jan 31, 2019
@TahaTesser TahaTesser added the c: proposal A detailed proposal for a change to Flutter label Apr 22, 2020
@kf6gpe kf6gpe added the P2 Important issues not at the top of the work list label May 29, 2020
@Hixie Hixie removed this from the None. milestone Aug 17, 2020
@flutter-triage-bot flutter-triage-bot bot added multiteam-retriage-candidate team-design Owned by Design Languages team triaged-design Triaged by Design Languages team labels Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a: fidelity Matching the OEM platforms better c: proposal A detailed proposal for a change to Flutter f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. P2 Important issues not at the top of the work list team-design Owned by Design Languages team triaged-design Triaged by Design Languages team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zoechi @Hixie @kf6gpe @sir-boformer @TahaTesser